Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL 1 shows user@hostname #319

Closed
broizter opened this issue Jun 24, 2023 · 3 comments
Closed

WSL 1 shows user@hostname #319

broizter opened this issue Jun 24, 2023 · 3 comments

Comments

@broizter
Copy link

user@hostname is always showing when running pure in WSL 1 even when setting pure_enable_container_detection to false. The only way I've found to hide user@hostname is to manually edit ~/.config/fish/functions/_pure_prompt_container.fish. Not sure if this is a bug or a configuration error on my end.

Env

Pure

4.4.3

Fish

fish, version 3.6.1

OS/distribution

Alpine Linux 3.18.2
@edouard-lopez
Copy link
Member

I released a new docker image with Fish 3.6.1 to attempt to reproduce. I'm also adding the 3.6.1 to the CI pipeline #320

Could you try to reproduce your bug in

❯ docker pull purefish/docker-fish:3.6.1
❯ docker run --rm --interactive --tty purefish/docker-fish:3.6.1

Then inside the container, install pure:

# host id will be different
nemo@ff4a1471e4b6 ~> fisher install pure-fish/pure

After installing, I got:
image
image

@edouard-lopez
Copy link
Member

I pushed a fixed with #320

@broizter
Copy link
Author

broizter commented Jun 29, 2023

#320 does indeed fix the issue. Unless you set pure_enable_container_detection to false it still thinks you're inside a container though but I guess WSL 1 is technically a container? Well it's not a big issue since it's at least possible to disable it now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants