Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user-agent to outgoing mail #414

Closed
frasertweedale opened this issue Jan 18, 2021 · 1 comment · Fixed by #415
Closed

Add user-agent to outgoing mail #414

frasertweedale opened this issue Jan 18, 2021 · 1 comment · Fixed by #415
Assignees
Labels
feature plugin Plugin interfaces and implementations

Comments

@frasertweedale
Copy link
Member

Describe the solution you'd like

It would be nice to include User-Agent header in outgoing mail, containing purebred version, and versions of any important components (purebred-email, hs-notmuch, libnotmuch). In particular this could help with bug reporting. And it is also nice to let the world know that you are using Purebred :)

Describe alternatives you've considered

Status quo (no user-agent header). It is not mandatory.

Additional context

Although User-Agent for mail is not formally defined by IETF, it is defined for netnews (https://tools.ietf.org/html/rfc5536#section-3.2.13) and we should probably conform to that specification.

@frasertweedale
Copy link
Member Author

It might be nice to do this via a "modify outgoing mail" plugin hook - even if it is "wired in" or enabled by default. It will help get the interfaces right, because surely there will be other use cases for manipulating the outgoing mail.

@frasertweedale frasertweedale added the plugin Plugin interfaces and implementations label Feb 3, 2021
frasertweedale added a commit that referenced this issue Feb 3, 2021
Add a plugin system.  The design of the system is described in [1]
Also provide a built-in plugin to add the User-Agent header to
outgoing mail (fixes #414).

Further improvements to the system and documentation will follow in
subsequent commits.

[1] https://frasertweedale.github.io/blog-fp/posts/2021-02-02-plugin-system-prototype.html

Fixes: #414
frasertweedale added a commit that referenced this issue Feb 3, 2021
Add a plugin system.  The design of the system is described in [1]
Also provide a built-in plugin to add the User-Agent header to
outgoing mail (fixes #414).

Further improvements to the system and documentation will follow in
subsequent commits.

[1] https://frasertweedale.github.io/blog-fp/posts/2021-02-02-plugin-system-prototype.html

Fixes: #414
frasertweedale added a commit that referenced this issue Feb 4, 2021
Add a plugin system.  The design of the system is described in [1]
Also provide a built-in plugin to add the User-Agent header to
outgoing mail (fixes #414).

Further improvements to the system and documentation will follow in
subsequent commits.

[1] https://frasertweedale.github.io/blog-fp/posts/2021-02-02-plugin-system-prototype.html

Fixes: #414
frasertweedale added a commit that referenced this issue Feb 4, 2021
Add a plugin system.  The design of the system is described in [1]
Also provide a built-in plugin to add the User-Agent header to
outgoing mail (fixes #414).

Further improvements to the system and documentation will follow in
subsequent commits.

[1] https://frasertweedale.github.io/blog-fp/posts/2021-02-02-plugin-system-prototype.html

Fixes: #414
@frasertweedale frasertweedale self-assigned this Feb 4, 2021
frasertweedale added a commit that referenced this issue Feb 9, 2021
Add a plugin system.  The design of the system is described in [1]
Also provide a built-in plugin to add the User-Agent header to
outgoing mail (fixes #414).

Further improvements to the system and documentation will follow in
subsequent commits.

[1] https://frasertweedale.github.io/blog-fp/posts/2021-02-02-plugin-system-prototype.html

Fixes: #414
frasertweedale added a commit that referenced this issue Feb 11, 2021
Add a plugin system.  The design of the system is described in [1]
Also provide a built-in plugin to add the User-Agent header to
outgoing mail (fixes #414).

Further improvements to the system and documentation will follow in
subsequent commits.

[1] https://frasertweedale.github.io/blog-fp/posts/2021-02-02-plugin-system-prototype.html

Fixes: #414
frasertweedale added a commit that referenced this issue Feb 12, 2021
Add a plugin system.  The design of the system is described in [1]
Also provide a built-in plugin to add the User-Agent header to
outgoing mail (fixes #414).

Further improvements to the system and documentation will follow in
subsequent commits.

[1] https://frasertweedale.github.io/blog-fp/posts/2021-02-02-plugin-system-prototype.html

Fixes: #414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature plugin Plugin interfaces and implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant