Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split README into section files #112

Merged
merged 2 commits into from
Feb 9, 2017
Merged

Split README into section files #112

merged 2 commits into from
Feb 9, 2017

Conversation

ruippeixotog
Copy link
Member

@ruippeixotog ruippeixotog commented Feb 8, 2017 •
edited
Loading

Fixes #102.

@ruippeixotog ruippeixotog mentioned this pull request Feb 8, 2017
Closed
leifwickland
leifwickland approved these changes Feb 8, 2017
View reviewed changes
Copy link
Collaborator

@leifwickland leifwickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to me you faithfully moved all the expected sections to their own pages.

melrief
melrief requested changes Feb 8, 2017
View reviewed changes
Copy link
Collaborator

@melrief melrief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to overrride behaviour for sealed families is broken, everything else LGTM

core/docs/overrride-behaviour-for-sealed-families.md Outdated
@@ -0,0 +1,85 @@
## Override behaviour for sealed families
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many r in the name of this file 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahah, nice catch! :D Fixed in fee4be3.

@melrief melrief merged commit 996d3ac into pureconfig:master Feb 9, 2017
@ruippeixotog ruippeixotog deleted the split-readme branch March 21, 2017 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leifwickland leifwickland leifwickland approved these changes

@melrief melrief melrief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ruippeixotog @leifwickland @melrief