New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify ConfigValueLocation to use URL instead of String #180
Modify ConfigValueLocation to use URL instead of String #180
Conversation
This looks good to me, but @leifwickland raised some concerns in #178 (comment) |
I've modified |
|
I prefer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Since |
I approved this, let's wait for another approval and merge. |
Approved. |
As suggested by @derekmorr in #178, this PR modifies
ConfigValueLocation
to usePath
instead ofString
to encode the location of failures.