Use UTF-8 charset when saving configs #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruippeixotog
requested changes
Aug 2, 2018
| @@ -255,9 +256,10 @@ package object pureconfig { | |||
| * @param outputStream The stream in which the configuration should be written | |||
| */ | |||
| def saveConfigToStream[Config](conf: Config, outputStream: OutputStream)(implicit writer: Derivation[ConfigWriter[Config]]): Unit = { | |||
| val printOutputStream = new PrintStream(outputStream) | |||
| // HOCON requires UTF-8 | |||
There was a problem hiding this comment.
Can you support this claim by adding a link to https://github.com/lightbend/config/blob/master/HOCON.md#unchanged-from-json on this comment?
ruippeixotog
approved these changes
Aug 2, 2018
|
Post facto approval from me. Sorry for my slow response time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the default charset is generally bad practice, and HOCON must always be in UTF-8 anyway.