Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add change marker for variables and watches #193

Merged
merged 8 commits into from
Jul 8, 2020
Merged

Conversation

puremourning
Copy link
Owner

No description provided.

@puremourning
Copy link
Owner Author

This change is Reviewable

@puremourning puremourning changed the title [WIPRemove hacky use of dicts and magic keys for variables [WIP] Remove hacky use of dicts and magic keys for variables Jul 7, 2020
@puremourning puremourning changed the title [WIP] Remove hacky use of dicts and magic keys for variables [WIP] Add change marker for variables and watches Jul 8, 2020
@puremourning
Copy link
Owner Author

just need to add a load of tests for this stuff :)

Copy link
Owner Author

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r2, 6 of 6 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mergify mergify bot merged commit 85667a5 into master Jul 8, 2020
@mergify mergify bot deleted the variables branch July 8, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant