Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document the default withCredentials = false #111

Open
joopringelberg opened this issue Feb 28, 2018 · 0 comments
Open

document the default withCredentials = false #111

joopringelberg opened this issue Feb 28, 2018 · 0 comments
Labels
type: enhancement A new feature or addition.

Comments

@joopringelberg
Copy link

The convenience functions (put, get, etc.) rely on the defaultRequest object. This is defined with the field 'withCredentials' to be false. This default will prevent browsers from storing cookies sent by a server on cross-domain requests (CORS). That is all according to specifications, but it took me a lot of time before I realized this caused the problem with authenticating with Couchdb that I worked on the last few days :-(.
As the content of the defaultRequest object is not in the module documentation, it is a somewhat hidden feature. Also, nothing will show up on the headers and content of requests and responses, making it hard to debug.

So I propose to include the defaults in the documentation, or to mention at least the 'withCredentials' value somewhere.

@garyb garyb added the type: enhancement A new feature or addition. label Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A new feature or addition.
Development

No branches or pull requests

2 participants