Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instances for 'unordered-collections' data types #60

Closed
JordanMartinez opened this issue Jul 17, 2019 · 2 comments
Closed

Add instances for 'unordered-collections' data types #60

JordanMartinez opened this issue Jul 17, 2019 · 2 comments
Assignees
Labels
type: enhancement A new feature or addition.

Comments

@JordanMartinez
Copy link
Contributor

Looking at unordered collections, these types should have instances as well:

  • HashMap
  • HashSet
@thomashoneyman thomashoneyman self-assigned this Aug 28, 2019
@thomashoneyman thomashoneyman added the type: enhancement A new feature or addition. label Aug 28, 2019
@thomashoneyman
Copy link
Contributor

thomashoneyman commented Aug 28, 2019

@JordanMartinez I agree those data types could use instances. As a matter of policy, though, thepurescript-contrib libraries only include dependencies from purescript or purescript-contrib. That way they can always be maintained by contributors without needing to wait on outside repositories to update. For example, we can guaranteed update all libraries in those two organizations for compiler releases even if other library authors aren't available at the time.

@JordanMartinez
Copy link
Contributor Author

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A new feature or addition.
Development

No branches or pull requests

2 participants