Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for pointer events #30

Merged
merged 4 commits into from
May 14, 2022

Conversation

gbagan
Copy link
Contributor

@gbagan gbagan commented May 11, 2022

@thomashoneyman
Copy link
Member

We try not to depend on libraries outside of the core, web, and contrib organizations in Halogen libraries, because doing so has historically caused problems when needing to make releases promptly after major breaking compiler changes. I think it's reasonable that we explore moving web-pointerevents into the purescript-web organization as you asked about before, and then depend on it here.

@garyb do you have any objections to this idea? Here's the source library:
https://github.com/gbagan/purescript-web-pointerevents

@garyb
Copy link
Member

garyb commented May 13, 2022

I'd agree with all that. The library is very much in line with the style of the other purescript-web libraries from what I see, so yep, would be a great candidate to include there if @gbagan is happy to bring it over!

@gbagan
Copy link
Contributor Author

gbagan commented May 14, 2022

I would be happy if web-pointerevents could be moved into purescript-web. I can help anyway.

@thomashoneyman
Copy link
Member

I have invited you to purescript-web. Once you accept the invitation, can you try transferring the repo?

@thomashoneyman thomashoneyman merged commit b462b73 into purescript-halogen:master May 14, 2022
@thomashoneyman
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants