Parse error for compiler version 0.13.x on v3.0.0 tag

[joneshf]

Howdy. I was looking into whether the tag at v3.0.0 could run on 0.13.x. Looks like there's one small thing that doesn't parse. It should be a non-breaking change as it parses with both 0.12.x and 0.13.x (unless I'm forgetting something). Would you be willing to accept a PR for the change and push out a v3.0.1? If so, it looks like a branch has to be made starting at v3.0.0, then I should be able to make a PR. If not, no big.

[natefaubion]

Yes, that would be great. I'm not sure how this didn't get caught leading up to 0.13.

[joneshf]

Great! Lemme know when a branch is made so I can submit a PR.

v3.0.0 is over a year old. The line was removed some time ago. Newer versions are compatible with compiler version 0.13.x. We ran into this because we're still on purescript-halogen v4.0.0 and it depends on v3.0.0 of this package.

Specifically, it depends on ElemSpec, so newer versions of this package would require changes to purescript-halogen based on the v4.0.0 tag. That seems more intrusive, though it would mean the updates from v4.0.0 on of this package would make its way into v4.x.x series of purescript-halogen.

[garyb]

Sorry, I only just realised you'd asked for a branch to be made for this. It's there now! https://github.com/slamdata/purescript-halogen-vdom/tree/v3-backport

[joneshf]

No worries. Thanks for the branch!

[garyb]

Released as v3.0.1. I've left the branch there, so if this doesn't do the trick we can always make further releases based on it 😉.

[joneshf]

Thanks!