Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purescript needs some JavaScript specific behaviors #10

Open
thautwarm opened this issue Feb 23, 2020 · 2 comments · Fixed by #14
Open

purescript needs some JavaScript specific behaviors #10

thautwarm opened this issue Feb 23, 2020 · 2 comments · Fixed by #14

Comments

@thautwarm
Copy link
Member

https://github.com/purescript/purescript-effect/blob/master/src/Effect.js#L12

    return function () {
      return f(a())();
    };

where f is a purescript function. PureScript functions are curried, hence they must accept one and only one argument, but here they call it without arguments.

To speed up calling functions and making FFI easier, I think it could be better for each argument of purescript function has a default value () or None.

@lfkdsk
Copy link
Collaborator

lfkdsk commented Feb 26, 2020

@thautwarm we could add default value in PySExpr (when gen define).

@thautwarm
Copy link
Member Author

thautwarm added a commit that referenced this issue Mar 4, 2020
…ent. fix #10

1. faster codegen: avoid pretty print when not specified. for #13
2. lighter volume: for generated files. type level computing can produce huge amount of code, to make generated code Git maintainable, we use bzip2 to compress stuffs. fix #13
3. option for pspy-blueprint changed.
@thautwarm thautwarm mentioned this issue Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants