Delay evaluation of it
blocks until test execution
#73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sometimes even pure code can have crashes (example: messing up the FFI when binding to a JavaScript library). I'd argue that test suites should deal with that, as they are a development tool.
Consider this test case:
Any program containing this definition will crash while loading the module, before it even calls
main
, becauseunsafeCrashWith
is not under any lambda, so it's evaluated immediately. The same example would work just fine (i.e. the crash would be caught by test runner) in Haskell and hspec, thanks to lazy evaluation.We can emulate the desired behavior using a hack that effectively wraps every
it
block in a lambda in the generated code.This would be a breaking change. "Normal" test code should compile just fine, but code that uses
it
in a generic way may need some eta-expansion to deal with the constrained type.