Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library design/intent/future #61

Open
garyb opened this issue May 16, 2018 · 3 comments
Open

Library design/intent/future #61

garyb opened this issue May 16, 2018 · 3 comments
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.

Comments

@garyb
Copy link
Member

garyb commented May 16, 2018

This library currently defines all its own types and a bunch of specialized functions, completely independent from the rest of the spec-based web/dom libraries. Do we want to keep it as it is, or should we remove the stuff that duplicates work done elsewhere and just have it implement the Context2D interface as per https://www.w3.org/TR/2dcontext?

I'm fine with either, but if it's the latter, I'll be tempted to make a purescript-web-context2d library that is just the minimal thing, and then base this library on top of that, so at least it can share types with the rest of the web ecosystem.

@garyb garyb added the question label May 16, 2018
@hdgarrood
Copy link
Collaborator

The latter option sounds good to me :)

@paf31
Copy link
Contributor

paf31 commented May 16, 2018

The latter option sounds preferable in that it seems like it would be possible to keep the API of this library fairly constant, which I like because it is used in the book. Perhaps this library could even become a thin veneer over the web-canvas library and move back to contrib.

@garyb
Copy link
Member Author

garyb commented May 16, 2018

Ok, sounds like we have a plan then. I'll work something up and open a PR.

@JordanMartinez JordanMartinez added purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump. and removed question labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.
Projects
None yet
Development

No branches or pull requests

4 participants