Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: imageSmoothingEnabled flag now exposed #92

Merged
merged 3 commits into from
May 28, 2024

Conversation

srijan-paul
Copy link
Contributor

@srijan-paul srijan-paul commented Apr 30, 2024

Expose the imageSmoothingEnabled flag from the Canvas API.

  • imageSmoothingEnabled ctx false is equivalent to ctx.imageSmoothingEnabled = false.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

Question

I also wanted to add some other calls, like imageSmoothingQuality and lineDashOffset. Should I add those to this same PR?

src/Graphics/Canvas.js Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
Copy link

@sigma-andex sigma-andex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sigma-andex sigma-andex merged commit 0120d41 into purescript-web:master May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants