Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started: no type declaration for main #87

Closed
crcdng opened this issue Jun 25, 2017 · 4 comments
Closed

Getting started: no type declaration for main #87

crcdng opened this issue Jun 25, 2017 · 4 comments

Comments

@crcdng
Copy link
Contributor

crcdng commented Jun 25, 2017

invoking pulp run in the Getting Started guide throws a warning No type declaration was provided for the top-level declaration of main....

@chexxor
Copy link
Collaborator

chexxor commented Jun 25, 2017

We can fix this by adding the type signature to that function, something like main :: forall e. Eff (console :: CONSOLE | e) Unit, but that might require explaining Eff, which doesn't belong in "Getting Started".

@i3games How do you propose this be fixed?

@crcdng
Copy link
Contributor Author

crcdng commented Jun 25, 2017

I just added pull request #90 which does add type declarations. If a compiler complains about something by default, I think it is better to confront beginners with learning about these concepts instead of saying "ignore these warnings".

@chexxor
Copy link
Collaborator

chexxor commented Jun 25, 2017

I can accept that reasoning. We should wait for other people to review this solution before accepting it.

@i3games Thanks so much for reporting these issues, and even fixing them!

@crcdng
Copy link
Contributor Author

crcdng commented Jun 25, 2017

You're welcome. I'd like to help out with documentation in the future as I'm getting more into PS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants