-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the F
and FT
alias (pending auto-migration tool)
#79
Comments
I would be in favor of dropping the alias. It allows to document the behaviour of the Alt instance for Except though (<|> accumulates foreign errors instead of keeping only the first one as it does for Either), so perhaps we should rather rename it to something more meaningful? What we decide here will have consequences for #74. |
I'm not in favour of this. I generally agree that writing out |
I'm in favor of dropping the alias. I'm not sure when we'll get a automatic upgrading tool. |
How about we update all code in this library to stop using the -- before
type FT = ExceptT MultipleErrors
unsafeReadTagged :: forall m a. Monad m => String -> Foreign -> FT m a
unsafeReadTagged tag value = ...
-- after
type FT = ExceptT MultipleErrors
unsafeReadTagged :: forall m a. Monad m => String -> Foreign -> ExceptT (NonEmptyList ForeignError) m a
unsafeReadTagged tag value = ... |
Sounds like a good compromise to me 👍 |
Done! |
F
aliasF
and FT
alias (pending auto-migration tool)
it's useless alias that makes code harder to read (not my words, but I agree)
type F = Except MultipleErrors
but this will be a breaking change
The text was updated successfully, but these errors were encountered: