Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog updates since v5.0.0 #83

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Conversation

milesfrain
Copy link
Contributor

@milesfrain milesfrain commented Jan 18, 2021

Description of the change

This PR updates the CHANGELOG in preparation for the upcoming release of this library.

Related: purescript/purescript#3985

CHANGELOG.md Outdated

New features:

Bugfixes:

Other improvements:
- Migrated CI to GitHub Actions and updated installation instructions to use Spago (#81)
- Added a CHANGELOG.md file and pull request template (#82 #83)
- Replaced unsafe FFI functions with `unsafeCoerce` (#72)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should call out that we specifically replaced unsafeToForeign and unsafeFromForeign

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we comma-separate multiple PRs? As in (#82, #83)?

@thomashoneyman thomashoneyman merged commit 32032a0 into purescript:master Jan 19, 2021
@milesfrain milesfrain deleted the patch-1 branch January 19, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants