Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v0.15.0 #203

Merged
merged 6 commits into from
Mar 15, 2022
Merged

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Backlinking to purescript/purescript#4244

Updates project to compile on v0.15.0 PureScript.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez added type: breaking change A change that requires a major version bump. purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 labels Mar 15, 2022
@JordanMartinez
Copy link
Contributor Author

Um.....

* Building project in /home/jordan/Programming/ps-libs/purescript/purescript-lists
[1 of 1] Compiling Data.List.Partial
[1/2 WildcardInferredType] src/Data/List/Partial.purs:21:1

  21  last :: forall a. Partial => List a -> a
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  Wildcard type definition has the inferred type
  
    a0
  
  in binding group last
  
  where a0 is a rigid type variable
          bound at (line 0, column 0 - line 0, column 0)

[2/2 WildcardInferredType] src/Data/List/Partial.purs:28:1

  28  init :: forall a. Partial => List a -> List a
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  Wildcard type definition has the inferred type
  
    List a0
  
  in binding group init
  
  where a0 is a rigid type variable
          bound at (line 0, column 0 - line 0, column 0)

           Src   Lib   All
Warnings   0     0     0  
Errors     2     0     2  

@JordanMartinez
Copy link
Contributor Author

Should we ignore these compiler warnings for now?

@rhendric
Copy link
Member

This is a compiler bug, right?

@JordanMartinez
Copy link
Contributor Author

Yeah, I just confirmed that it doesn't appear in v0.14.5 but does in v0.14.7.

@JordanMartinez
Copy link
Contributor Author

Should we ignore these compiler warnings for now?

And to clarify, I mean ignore the warning in this repo for now, so that we can continue updating other libraries that depend on this one and agreeing to come back and fix this bug in the compiler before v0.15.0 is released.

@thomashoneyman
Copy link
Member

I think we should continue despite the warning, with the knowledge we need to sweep back around to it.

@JordanMartinez
Copy link
Contributor Author

CI builds now.

@JordanMartinez JordanMartinez merged commit e11c5ba into purescript:master Mar 15, 2022
@JordanMartinez JordanMartinez deleted the update-to-0.15 branch March 15, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants