Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for 0.12 #27

Merged
merged 4 commits into from
May 23, 2018
Merged

Updates for 0.12 #27

merged 4 commits into from
May 23, 2018

Conversation

garyb
Copy link
Member

@garyb garyb commented May 23, 2018

No description provided.

@hdgarrood
Copy link
Contributor

Are we not doing #23 then?

@garyb
Copy link
Member Author

garyb commented May 23, 2018

I think not for now - it's a nice to have rather than something that is a common problem, and needs quite a bit of library rearrangement to work (functors having to move above bifunctor).

I'm still not really pro-Functor1 either - the quantified constraint version I'd be fine with with rmap = map if we really wanted to keep that function though (another reason to prefer map at the moment is it's more efficient since it's not implemented via dimap or bimap).

@hdgarrood
Copy link
Contributor

Ah ok, I see. It seems a little odd to me to object to Functor1 given that we have eg Eq1, Ord1, already, though; is there something which is different about Functor1?

@garyb
Copy link
Member Author

garyb commented May 23, 2018

Eq1 is required for some instances to be usable (like Eq for Free) or for some types to have Eq at all (Mu), but Functor1 doesn't give us anything that isn't already covered by Functor , aside from the ability to use it as a superclass of Bifunctor and Profunctor.

I could be wrong about the second part of that though... I'm perhaps not imaginative enough to come up with something like either of those Eq1 cases I mentioned 😄. I see your point though, perhaps it's just bias on my part because I know places I needed Eq1 so can see past the gross-ness of its necessity.

@garyb garyb merged commit 1de584b into master May 23, 2018
@garyb garyb deleted the compiler/0.12 branch May 23, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants