update replace' to reflect the existence of optional capturing groups #126
Conversation
| foreign import _replaceBy | ||
| :: (forall r. r -> Maybe r) | ||
| -> (forall r. Maybe r) | ||
| -> Regex | ||
| -> (String -> Array (Maybe String) -> String) | ||
| -> String | ||
| -> String |
There was a problem hiding this comment.
I moved this import above the line that references it, for consistency with the placement of _match and _search.
| while (typeof (group = arguments[i++]) !== "number") { | ||
| groups.push(group == null ? nothing : just(group)); | ||
| } |
There was a problem hiding this comment.
The typeof check looks odd, but is necessary to handle both possible cases:
match, group1, group2, ..., offset, string(rcontains no named capturing groups); andmatch, group1, group2, ..., offset, string, groups(rcontains named capturing groups).
src/Data/String/Regex.purs
Outdated
|
|
||
| foreign import replaceBy :: Regex -> (String -> Array String -> String) -> String -> String | ||
| -- | Transforms occurrences of the `Regex` using a function of the matched | ||
| -- | substring and a list of groups of type `Maybe String`, where `Nothing` |
There was a problem hiding this comment.
Perhaps ”captured substrings”, ”submatches” or ”submatch strings”, like in the previous comment? I’m not sure ”groups” makes much sense to denote what was captured.
There was a problem hiding this comment.
Good idea. I will make this change.
|
Is there anything stopping this from getting merged? We have 2 approvals already. |
|
I believe we're giving @davidchambers a chance to update the documentation as per: |
|
Just curious, but if the change is that small, why not just make the edit ourselves so this can be merged? I'm not sure whether that would be impolite or not. |
|
I think in this case since the author indicated they plan to make the change that we should let them go through with it. If we reach the point where we need to release this library then we can make the edit and merge, but in general it is polite to allow pull request authors to make changes to their own pull requests whenever possible. |
davidchambers
force-pushed
the
replace
branch
2 times, most recently
from
7e9f362
to
abaedd6
Compare
|
I have updated the wording as discussed. Could someone investigate the build failure? It does not seem related to my changes. |
|
It's because CI is still on Anything else we need to do here? Or can this be merged? |
|
Thanks for the fix, @JordanMartinez. I transposed the commits; both are now green. As far as I am concerned, this pull request is ready to merge. :) Once this pull request has been merged I will propose a second breaking change. ;) |
|
Merged! |
This pull request does for
replace'what #32 did formatch.This pull request also fixes a few typos, renames a parameter (
s2→s), and removes the mutation ofargumentsin_replaceBy(formerlyreplaceBy).I would like to propose another breaking change to this function, so if you merge this pull request please do not release a new version of the package immediately. :)