Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v0.14.0-rc3 #133

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Update to v0.14.0-rc3 #133

merged 2 commits into from
Nov 8, 2020

Conversation

paluh
Copy link
Contributor

@paluh paluh commented Oct 20, 2020

@JordanMartinez
Copy link
Contributor

CI is now failing due to two reasons:

  • Foldable1 now includes foldr1 and foldl1
  • kind annotation compiler warnings

@JordanMartinez
Copy link
Contributor

@paluh, I've fixed the kind annotations in this PR to your branch: paluh#1

Please merge that when you get a chance. After its merged, the only thing blocking this PR is the purescript-lazy dependency. Its Foldable1 instance for Lazy needs to be updated.

@paluh
Copy link
Contributor Author

paluh commented Oct 29, 2020

@JordanMartinez I'm not sure how I was able to don't notice these warnings. Sorry. You fix is included in this PR now.

@JordanMartinez
Copy link
Contributor

This is blocked by purescript-arrays now due to using it as a test dependency.

JordanMartinez
JordanMartinez approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI now builds and I've verified that unicode syntax isn't being used here.

@thomashoneyman thomashoneyman merged commit 982fbbd into purescript:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanMartinez JordanMartinez JordanMartinez approved these changes

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paluh @JordanMartinez @thomashoneyman