Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new module Type.RowList #48

Merged
merged 1 commit into from
May 26, 2019
Merged

Add new module Type.RowList #48

merged 1 commit into from
May 26, 2019

Conversation

hdgarrood
Copy link
Contributor

Refs #43, fixes #46.

RowList-related types and classes have been removed from Type.Row and
moved into Type.RowList, in order to prepare for an upcoming compiler
change whereby a module will no longer be allowed to re-export both a
type and a class of the same name; see purescript/purescript#3502

Refs #43, fixes #46.

RowList-related types and classes have been removed from Type.Row and
moved into Type.RowList, in order to prepare for an upcoming compiler
change whereby a module will no longer be allowed to re-export both a
type and a class of the same name; see purescript/purescript#3502
@hdgarrood hdgarrood requested a review from garyb May 26, 2019 22:46
Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is actually better than the way we had it before! 🙂

@hdgarrood hdgarrood merged commit 10aaed6 into master May 26, 2019
@hdgarrood hdgarrood deleted the reorg-modules branch May 26, 2019 23:14
@hdgarrood
Copy link
Contributor Author

Thanks! Yeah it was @LiamGoodacre's idea, and I think this was definitely the right move given that we had to break it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need major version increment after recent change removing export of Type.Row
2 participants