Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have more information in DuplicateSelectiveImport #4524

Open
flip111 opened this issue Dec 25, 2023 · 0 comments
Open

Have more information in DuplicateSelectiveImport #4524

flip111 opened this issue Dec 25, 2023 · 0 comments

Comments

@flip111
Copy link

flip111 commented Dec 25, 2023

The DuplicateSelectiveImport warning currently only records the name of the module that is duplicated. Could it additionally record in the data structures:

  • line numbers of duplicates :: List Integer
  • "It could be replace with: ..." :: Text

This way refactoring tools can just remove the lines and replace it with the suggested line. Otherwise the tool has to parse the purescript source code again when it has been already parsed.

I don't mind either way if the textual message to the user changes or not. But having these additions to the JSON would be great. So either as part of the message or as separate fields in the JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant