Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link example of spago + parcel in the README #83

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Link example of spago + parcel in the README #83

merged 4 commits into from
Jan 22, 2019

Conversation

f-f
Copy link
Member

@f-f f-f commented Jan 21, 2019

@f-f f-f requested a review from vapaj January 21, 2019 07:06
vapaj
vapaj approved these changes Jan 21, 2019
View reviewed changes
Copy link
Collaborator

@vapaj vapaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@justinwoo
Copy link
Contributor

Is there not a smaller example you can link also? Maybe link https://github.com/f-f/purescript-react-basic-todomvc and write somethign about how output/ has CommonJS modules you can import

@f-f
Copy link
Member Author

f-f commented Jan 21, 2019

@justinwoo @vapaj how does it look now?

justinwoo
justinwoo approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@justinwoo justinwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo

@f-f f-f merged commit fd91f9b into master Jan 22, 2019
@f-f f-f deleted the more-faq branch January 22, 2019 11:18
elliotdavies pushed a commit to elliotdavies/spago that referenced this pull request Jul 1, 2019
@f-f
Link examples of spago + parcel in the README (purescript#83)
6032129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwoo justinwoo justinwoo approved these changes

@vapaj vapaj vapaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f-f @justinwoo @vapaj