Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network intercept functions, wait function, silence page errors #9

Merged
merged 4 commits into from Feb 4, 2018
Merged

Conversation

dgendill
Copy link
Contributor

  1. Some initial work on the network interception functions of phantom.
  2. When evaluating code on a page, if that page has errors unrelated to your own code, you'll see them in the console. For that reason, I've added a function to silence page errors.
  3. For convenience I've added wait function to Page.
  4. Since page.evaluate can return undefined, I check for that before accessing the type property.

@dgendill dgendill merged commit f535dda into purescripters:master Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant