Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new characters for recruitment system #12

Merged
merged 5 commits into from
Oct 6, 2021

Conversation

toosyou
Copy link
Contributor

@toosyou toosyou commented Oct 1, 2021

  • Add the following characters to the recruitment system
    • Archangel Saint Milae
    • Well-Respected Aristocrat Lotiya
    • Dreameater Aridya
    • Magical Knight Tyrella
    • Angel of Punishment
    • Angel of Bliss
  • Add "Weaken" tag to Snake Queen Mesmiia
  • Replace the original recruitment report form with the official discord link
  • Known issue
    • src/images/char_{158-160}.png are templates.

Copy link
Owner

@purindaisuki purindaisuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work.
When adding a new character, I would check the following files.

  1. character.json
    Determine id by the game data and the first character of id by the rarity.
    Calculate stats by dividing the values presented by the Gacha page in the game by 1.1^59.
    Determine potentialType by the pattern of the potential.
  2. character and page string files
    Add information for the new character and the update at least in Chinese and English.
  3. characterSkill.ts
    Add character skills for the battle simulator.
  4. line_up_data.json
    Add the new character id for lineup analysis.
  5. character images

For recruitment, 1., 2., 5. are necessary. You can find the images from the official website.

src/data/character.json Outdated Show resolved Hide resolved
src/data/string/page_zh-TW.json Outdated Show resolved Hide resolved
src/data/string/page_zh-TW.json Outdated Show resolved Hide resolved
@toosyou
Copy link
Contributor Author

toosyou commented Oct 5, 2021

I somehow obtained the images and fixed the character IDs.
However, I still don't know how to get the potential types, maybe somewhere within the game data?
Please let me know if there's anything I missed!
Thanks for the help!

@purindaisuki
Copy link
Owner

purindaisuki commented Oct 5, 2021

There are four potential types which are attacker, defender, supporter, and N/R type, a type shared by N/R characters. Note that the attacker, defender, and supporter here are not identical to character positions. (e.g. Juneau is an attacker in character position but a supporter in potential type.)
You can find the type by comparing the potential material requirement of the new character to that of an existed character.

@toosyou
Copy link
Contributor Author

toosyou commented Oct 6, 2021

I can only confirm Dreameater Aridya's potential type but not Well-Respected Aristocrat Lotiya's (since I don't have her), so I just assume she's attacker type.
I'll check for any feedbacks and fix that later.
I hope it's acceptable for the recruitment update~

@james11112222
Copy link

I can only confirm Dreameater Aridya's potential type but not Well-Respected Aristocrat Lotiya's (since I don't have her), so I just assume she's attacker type. I'll check for any feedbacks and fix that later. I hope it's acceptable for the recruitment update~

You're right, Lotiya has the same pot type with Baal.
However there is one thing has to be corrected, Aridya's init atk is 675.2 and init hp is 4729.6 according to the stats in Gacha page which are 186896 and 1309160.

Thanks for your working, I can't wait to see the toolbox updated.
And, of course, the author of toolbox, purin's efforts.

@toosyou
Copy link
Contributor Author

toosyou commented Oct 6, 2021

You're right, Lotiya has the same pot type with Baal. However there is one thing has to be corrected, Aridya's init atk is 675.2 and init hp is 4729.6 according to the stats in Gacha page which are 186896 and 1309160.

My game page shows 186896 and 1309160 too, but it also shows I have a 15% increase for each ATK and HP from training(調教).
So I am a little bit confused.

@purindaisuki
Copy link
Owner

My game page shows 186896 and 1309160 too, but it also shows I have a 15% increase for each ATK and HP from training(調教).
So I am a little bit confused.

Base ATK * base HP should be around 3.2 m and 3.5 m for eternal and SP characters respectively.

Thanks for your work, I think it's in good shape but I still need your help with the following things:

  1. Although Japanese and Korean are not available, we still need to let the users know the toolbox is updated. Can you please add the update messages (in English) to page_ja.json and page_ko.json?
  2. For the update messages, can you please make them more consistent with the previous messages? (You can just copy the previous messages and replace the character names.)

@toosyou
Copy link
Contributor Author

toosyou commented Oct 6, 2021

However there is one thing has to be corrected, Aridya's init atk is 675.2 and init hp is 4729.6 according to the stats in Gacha page which are 186896 and 1309160.
Base ATK * base HP should be around 3.2 m and 3.5 m for eternal and SP characters respectively.

I think you're right(the collection page confuses me). It should be fixed now!

I also adjusted the update logs so that they are more consistent with the convention!
Please let me know if there's still anything missing.
Thank you for your help!

Copy link
Owner

@purindaisuki purindaisuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll deploy it soon. Thanks so much.

@purindaisuki purindaisuki merged commit 06c75ba into purindaisuki:master Oct 6, 2021
@toosyou
Copy link
Contributor Author

toosyou commented Jan 4, 2022

Happy new year! I have been working on the new recruitable characters. However, I searched everywhere but I couldn't find the characters' small pictures (160 x 160 ones). I thought the official website has them :(
I would be so grateful if you could give me some hints! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants