Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcode snippet shouldn't use extract() #31

Closed
MickeyKay opened this issue Oct 27, 2014 · 2 comments
Closed

Shortcode snippet shouldn't use extract() #31

MickeyKay opened this issue Oct 27, 2014 · 2 comments
Labels
Duplicate

Comments

@MickeyKay
Copy link
Contributor

The usage of extract() is now discouraged, even in WP core https://core.trac.wordpress.org/ticket/22400. As such, I recommend you remove this from the shortcode snippet.
@MickeyKay MickeyKay mentioned this issue Oct 27, 2014
Closed
@purplefish32
Copy link
Owner

Do you mind sending a pull request ?

@purplefish32
Copy link
Owner

Dupe : #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@purplefish32 @MickeyKay