Skip to content

Commit

Permalink
resources: virt: Remove unnecessary early exit from CheckApply
Browse files Browse the repository at this point in the history
I don't think this early exit is necessary any more, since the main
CheckApply function really just spawns out to the different sub workers
which all individually check the apply variable.

If I'm wrong, we can revert this. It was @roidelapluie that noticed the
check here to begin with.
  • Loading branch information
purpleidea committed Feb 26, 2017
1 parent 79923a9 commit c480bd9
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions resources/virt.go
Original file line number Diff line number Diff line change
Expand Up @@ -836,11 +836,6 @@ func (obj *VirtRes) CheckApply(apply bool) (bool, error) {
// FIXME: should we wait to ensure machine is booted before continuing?
// it may be useful to wait for guest agent to hotplug some ram or cpu!

if !apply {
return false, nil
}
// remaining apply portion

// mem & cpu checks...
if !obj.absent {
if c, err := obj.attrCheckApply(apply, dom); err != nil {
Expand Down

0 comments on commit c480bd9

Please sign in to comment.