Add support for CentOS 7.0.

[bowlofeggs]

No description provided.

[jackdpeterson]

Can we get this merged in?

[purpleidea]

@rbarlow sorry I didn't do a proper review before today. Here it is:

The yaml stuff is of course, perfect. I didn't check in detail, but I have no worries.
As for the puppet changes, I think the more general solution should be to have two params:

$misc_gluster_baseurl
$misc_gluster_gpgkeys

The existing $misc_gluster_repo could be renamed to $misc_gluster_baserepo

And if the top two baseurl or gpgkeys are set, then it overwrites the gluster::repo settings that happen...

Does this make sense? I think it would be more straightforward this way, and only requires changes in params.pp and repo.pp

If you prefer to not make these changes, I'll merge this, and then patch on top. Let me know!

Thanks again!!

[jackdpeterson]

@rbarlow

Did you encounter the following at all?

Error: Failed to apply catalog: Could not find dependency File[/var/lib/puppet/tmp/] for File[/var/lib/puppet/tmp/gluster/] at /etc/puppet/modules/gluster/manifests/vardir.pp:49

[bowlofeggs]

On 11/20/2014 03:29 PM, Jack Peterson wrote:

Did you encounter the following at all?

Error: Failed to apply catalog: Could not find dependency
File[/var/lib/puppet/tmp/] for File[/var/lib/puppet/tmp/gluster/] at
/etc/puppet/modules/gluster/manifests/vardir.pp:49

I did not see this during my dev/testing. @purpleidea, did you?

[bowlofeggs]

On 11/20/2014 01:00 PM, James wrote:

If you prefer to not make these changes, I'll merge this, and then patch
on top. Let me know!

I think I can do this, but it might have to wait a bit.

[purpleidea]

On Thu, Nov 20, 2014 at 3:29 PM, Jack Peterson notifications@github.com
wrote:

@rbarlow https://github.com/rbarlow

Did you encounter the following at all?

Error: Failed to apply catalog: Could not find dependency
File[/var/lib/puppet/tmp/] for File[/var/lib/puppet/tmp/gluster/] at
/etc/puppet/modules/gluster/manifests/vardir.pp:49

Did you read the docs?

cough

https://github.com/purpleidea/puppet-gluster/blob/master/DOCUMENTATION.md#i-get-a-file-dependency-error-when-running-puppet-gluster

Hope that helps.

Cheers,
James

[jackdpeterson]

Ahh cheers, missed that yesterday :-)

[purpleidea]

@rbarlow This is merged in now, thanks! d61ae97

I tried implementing my: $misc_gluster_baseurl + $misc_gluster_gpgkeys patch, but I decided your approach was better! I added one nitpick commit on top of yours. Please have a look so that you see what I nitpicked on, and let me know if you disagree with anything. As an aside, read the commit message:

784bc89

This does some small fixes to rbarlow's original commit (merged). Originally, I wasn't sure it was the correct patch, and I implemented something different to try it out a different way, but in the end, I realized that rbarlow's method was better! rbarlow, you're on your way to becoming a puppet superstar!

This patch just makes some small changes so that the code is consistent,
and nitpitcks a bit.

So, IOW, thanks. Please test and let me know if there are any other issues!