New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow setting the mount point uid and gid #41

Closed

aamerik wants to merge 1 commit into purpleidea:master from aamerik:master

aamerik commented Apr 9, 2015

No description provided.


          allow setting the mount point uid and gid

6dbc6f4

Owner

purpleidea commented Apr 10, 2015

Quick review:

indentation uses tabs not spaces
should only be a short patch, unnecessary to change every parameters comment indenting
param names should be owner / group not mount_uid_etc...
i think the code you want looks like:

$owner = ''

...

owner => "${owner}" ? {
'' => undef,
default => $owner,
},

Hope this makes sense. Test, rebase and let me know :)

aamerik closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment