Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no_std to libmimalloc-sys lib.rs & use libc for platform deps #61

Closed
wants to merge 2 commits into from
Closed

Add no_std to libmimalloc-sys lib.rs & use libc for platform deps #61

wants to merge 2 commits into from

Conversation

asrael
Copy link

@asrael asrael commented Feb 28, 2021

Fixes #59

thomcc
thomcc suggested changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As-is this is more or less completely wrong, sadly.

.cargo/config Outdated Show resolved Hide resolved
@asrael
Copy link
Author

asrael commented May 14, 2021

This is probably stale at this point, I haven't kept up with mimalloc and am instead using a different allocator.

@asrael asrael closed this May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcc thomcc thomcc requested changes

@Systemcluster Systemcluster Systemcluster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libmimalloc-sys is missing #![no_std] and injects std into my no_std crate
3 participants
@asrael @thomcc @Systemcluster