Mark libmimalloc_sys as no_std to support no_std users.
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mimalloc_ruustlibrary is marked as#![no_std], yetlibmimalloc-sysis not marked as#![no_std]sono_stdusers ofmimalloc_rustwill pull in thestdlibrary as a result. This seems like a small oversight.My specific use-case for this change is because I wish to create a library that does not link to
stdfor a smaller size, but that still requires allocations.I did not thoroughly check if this will adversely affect other end users, I'm hoping CI/CD will catch these.