Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tls Tester #85

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Implement Tls Tester #85

merged 1 commit into from
Sep 1, 2021

Conversation

binarymist
Copy link
Member

@binarymist binarymist commented Sep 1, 2021

  • Implement retries and timeouts for initialising Testers
  • Add Minimum Supported Versions section to README
  • Change formatting in README
  • Document changes around Job layout
  • Change casing to line-up with Definitions
  • Change references to buildUserConfig throughout to job to line-up with Definitions
  • Add version config to validate Job files
  • Remove requirement to configure testerFeedbackComms.medium on client-side as the orchestrator now controls this
  • schamas/job.js is a duplicate of the same file in the orchestrator
  • Updated the Job file testResources to include the Tls Tester. type testSession is now type appScanner. See the Job file documentation for further details
  • Remove the ability to specify Tester report formats, we now just provide them all

Checklist

  • I have read the contributing guidelines
  • I have read the documentation
  • I have included a descriptive Pull Request title
  • I have included a Pull Request description of my changes
  • I have included tests where/when required (see contributing guidelines)
  • I have included documentation modifications/additions where/when required (see contributing guidelines)

@binarymist binarymist merged commit d8fdcfa into main Sep 1, 2021
@binarymist binarymist deleted the binarymist/tls-scanner branch September 1, 2021 02:09
@coveralls
Copy link

coveralls commented Sep 1, 2021

Pull Request Test Coverage Report for Build 1188454232

  • 462 of 485 (95.26%) changed or added relevant lines in 11 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 91.45%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/schemas/job.js 298 301 99.0%
src/models/model.js 29 38 76.32%
src/presenter/apiDecoratingAdapter.js 87 98 88.78%
Files with Coverage Reduction New Missed Lines %
src/presenter/apiDecoratingAdapter.js 3 78.74%
Totals Coverage Status
Change from base Build 995752026: 0.9%
Covered Lines: 1797
Relevant Lines: 1965

💛 - Coveralls

@binarymist
Copy link
Member Author

This was part of #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants