feat(otel): add ctx logger

purposeinplay · Jun 14, 2024 · e97bdd2 · e97bdd2
1 parent bdf94f3
commit e97bdd2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/otel/go.mod b/otel/go.mod
@@ -3,7 +3,7 @@ module github.com/purposeinplay/go-commons/otel
 go 1.22
 
 require (
-	github.com/purposeinplay/go-commons/grpc v0.0.26
+	github.com/purposeinplay/go-commons/grpc v0.0.27
 	github.com/stretchr/testify v1.9.0
 	go.opentelemetry.io/contrib/instrumentation/runtime v0.52.0
 	go.opentelemetry.io/otel v1.27.0

diff --git a/otel/go.sum b/otel/go.sum
diff --git a/otel/test/integration_test.go b/otel/test/integration_test.go
@@ -21,6 +21,7 @@ import (
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/credentials/insecure"
 	"google.golang.org/grpc/test/bufconn"
+	"github.com/grpc-ecosystem/go-grpc-middleware/logging/zap/ctxzap"
 )
 
 func TestTracer(t *testing.T) {
@@ -130,17 +131,23 @@ func TestIntegration(t *testing.T) {
 		}
 	})
 
+	logger, err := zap.NewDevelopment()
+	req.NoError(err)
+
 	greeterClient1 := greetpb.NewGreetServiceClient(conn1)
 
 	grpcServer2, err := commonsgrpc.NewServer(
 		commonsgrpc.WithGRPCListener(lis2),
 		commonsgrpc.WithDebug(zap.NewExample(), true),
 		commonsgrpc.WithOTEL(),
+		commonsgrpc.WithUnaryServerInterceptorLogger(logger),
 		commonsgrpc.WithRegisterServerFunc(func(server *grpc.Server) {
 			greetpb.RegisterGreetServiceServer(server, &greeterService{
 				greetFunc: func(ctx context.Context, req *greetpb.GreetRequest) (*greetpb.GreetResponse, error) {
 					t.Log("greet func server 2")
 
+					ctxzap.Info(ctx, "zap log")
+
 					return greeterClient1.Greet(ctx, req)
 				},
 			})