Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove open report getter #273

Conversation

ChristopherPHolder
Copy link
Collaborator

@ChristopherPHolder ChristopherPHolder commented Mar 6, 2024

TL;DR

Removes the openReport and dryRun getters.

Removes the use of the interactive get for the collect command implementation.

Improves collect command typing.

Adds unit test for open-report

Describe

This MR is the start of the elimination of option getter.

The motivation for this is described in this issue: #272

But in short it needs to happen to be able to migrate to ESM.

Additionally it removes the use of the interactive from the collect command implementation.

To do so it required fixing the type of collect command which still requires further improvements as it should not require the use of any.

Disclaimers

The collect command does not follow the same coding style as the inti command and uses a lot of promise chaining, This MR does not really help fix the code smell. In fact it makes it more complex.

We can deal with the issues related to that after the ESM migration.

This comment has been minimized.

@ChristopherPHolder ChristopherPHolder changed the base branch from main to chore/upgrade-yargs March 6, 2024 17:51

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see the get pattern go away!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

…t-openReport

# Conflicts:
#	package-lock.json
#	package.json
Copy link

☕ Order Coffee ☕

Date/Time: 2024-03-14 14:44

Step Name Gather Mode Performance Accessibility Best Practices Seo Pwa
🧭 Navigate to coffee cart navigation 🔒 82 97 100 85 30
☕ Select coffee timespan 11/11 - 7/7 - -
✔ Coffee selected snapshot Ø 3/3 15/16 5/5 7/9 -
🛒 Checkout order timespan 13/13 - 7/7 - -
🧾 Order checked out snapshot Ø 3/3 17/18 5/5 7/9 -
💌 Submit order timespan 13/13 - 7/7 - -
📧 Order submitted snapshot Ø 3/3 15/16 5/5 7/9 -
🧭 Navigate to github navigation 🔒 99 96 100 85 30
🔒 Budgets

🧭 Navigate to coffee cart

Resource Size Budget

Resource Type Transfer Size Over Budget
Script 162.48 KB 162.48 KB
Stylesheet 3.66 KB 3.66 KB
Image 0 Bytes -
Media 0 Bytes -
Font 0 Bytes -
Document 1.19 KB -
Other 709 Bytes -
Third-party 95.33 KB -

Resource Count Budget

Resource Type Requests Over Budget
Script 2 1 request
Stylesheet 2 1 request
Image 0 -
Media 0 -
Font 0 -
Document 1 -
Other 2 2 requests
Third-party 3 3 requests

Timing Budget

Metric Measurement Over Budget
Speed Index 9193 ms 9183 ms
Largest Contentful Paint 2992 ms 2982 ms
First Contentful Paint 1741 ms 1731 ms
Total Blocking Time 176 ms 166 ms
Cumulative Layout Shift 0.00 -

🧭 Navigate to github

Resource Size Budget

Resource Type Transfer Size Over Budget
Stylesheet 41 Bytes 41 Bytes
Script 41 Bytes 41 Bytes
Image 0 Bytes -
Media 0 Bytes -
Font 0 Bytes -
Document 1016 Bytes -
Other 17 Bytes -
Third-party 17 Bytes -

Resource Count Budget

Resource Type Requests Over Budget
Stylesheet 2 1 request
Script 2 1 request
Image 0 -
Media 0 -
Font 0 -
Document 1 -
Other 2 2 requests
Third-party 4 4 requests

Timing Budget

Metric Measurement Over Budget
Largest Contentful Paint 1629 ms 1619 ms
First Contentful Paint 885 ms 875 ms
Speed Index 885 ms 875 ms
Total Blocking Time 120 ms 110 ms
Cumulative Layout Shift 0.00 -

Copy link

❗❗❗ report generated by this PR ❗❗❗

☕ Order Coffee ☕

Date/Time: 2024-03-14 14:44

Step Name Gather Mode Performance Accessibility Best Practices Seo Pwa
🧭 Navigate to coffee cart navigation 🔒 90 97 100 85 30
☕ Select coffee timespan 11/11 - 7/7 - -
✔ Coffee selected snapshot Ø 3/3 15/16 5/5 7/9 -
🛒 Checkout order timespan 13/13 - 7/7 - -
🧾 Order checked out snapshot Ø 3/3 17/18 5/5 7/9 -
💌 Submit order timespan 13/13 - 7/7 - -
📧 Order submitted snapshot Ø 3/3 15/16 5/5 7/9 -
🧭 Navigate to github navigation 🔒 99 96 100 85 30
🔒 Budgets

🧭 Navigate to coffee cart

Resource Size Budget

Resource Type Transfer Size Over Budget
Script 162.51 KB 162.51 KB
Stylesheet 3.66 KB 3.66 KB
Image 0 Bytes -
Media 0 Bytes -
Font 0 Bytes -
Document 1.19 KB -
Other 700 Bytes -
Third-party 95.32 KB -

Resource Count Budget

Resource Type Requests Over Budget
Script 2 1 request
Stylesheet 2 1 request
Image 0 -
Media 0 -
Font 0 -
Document 1 -
Other 2 2 requests
Third-party 3 3 requests

Timing Budget

Metric Measurement Over Budget
Largest Contentful Paint 3191 ms 3181 ms
Speed Index 1867 ms 1857 ms
First Contentful Paint 1681 ms 1671 ms
Total Blocking Time 161 ms 151 ms
Cumulative Layout Shift 0.00 -

🧭 Navigate to github

Resource Size Budget

Resource Type Transfer Size Over Budget
Stylesheet 41 Bytes 41 Bytes
Script 41 Bytes 41 Bytes
Image 0 Bytes -
Media 0 Bytes -
Font 0 Bytes -
Document 1017 Bytes -
Other 0 Bytes -
Third-party 0 Bytes -

Resource Count Budget

Resource Type Requests Over Budget
Stylesheet 2 1 request
Script 2 1 request
Image 0 -
Media 0 -
Font 0 -
Document 1 -
Other 1 1 request
Third-party 3 3 requests

Timing Budget

Metric Measurement Over Budget
Largest Contentful Paint 1560 ms 1550 ms
First Contentful Paint 880 ms 870 ms
Speed Index 880 ms 870 ms
Total Blocking Time 130 ms 120 ms
Cumulative Layout Shift 0.00 -

@ChristopherPHolder ChristopherPHolder merged commit a5e7b7e into chore/upgrade-yargs Mar 14, 2024
3 checks passed
@ChristopherPHolder ChristopherPHolder deleted the chore/upgrade-yargs-remove-get-openReport branch March 14, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants