Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Release 1.4.0 #1364

Merged
merged 40 commits into from
Jun 20, 2024
Merged

Main Release 1.4.0 #1364

merged 40 commits into from
Jun 20, 2024

Conversation

rohitmalhotra1420
Copy link
Collaborator

Fixes Issue

Fixes #1363

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

HarshRajat and others added 30 commits May 15, 2024 20:50
added relative imports for better management
…eb-chat

Fixed ChatUI Components responsiveness
* fix: fixed lint issues

* fix: added test for chat preview search list

* fix: fixed review comment

* Update ChatPreviewSearchList.tsx
* fix: fixed support chat init issue

* fix: fixed lint errors
* Fixed responsiveness in mobile for UIWeb:Chat

* fixes text alignment on frames preview link to come on right

* scroll bar fixes

* fixed reaction picker position, tweaked group type text, removed add button from define conditions in gated group

* removed unnecessary console.debug

* removed unnecessary console.debug

* Resolved comments, fixed curved edges go away, fixed correct time placement in ChatBubble

* Resolved comments
When copying pending wallet address in the group info, only half of the wallet address was getting
copied

#1297
Tooltip was not properly aigned in the group Info in UIWeb

#1299
Fixed the scrollbar issue in the member list in group info in uiweb

#1298
…-when-groupchat-is-encrypted

🐛 [BUG] - <Increase bg blur when group/chat is encrypted>
🐛 [BUG] - <Skeleton loading in dark mode appears like light mode in chat>
🐛 [BUG] - Chat  badge getting updated for active/opened conversation>
* feat: integrating spaceid in uiweb

* fix: fixed project id setting error

* fix: removed unnecessary code

* fix: added space id

* Update AddWallets.tsx

* fix: made some optimisations

* fix: fixed lint issues

---------

Co-authored-by: KlausMikhaelson <satyamsingh5076@gmail.com>
mishramonalisha76 and others added 9 commits May 29, 2024 23:19
…allet-address-issue

fix: pending wallet address copy issue fixed
…erly-aligned

fix: tooltip was not properly aligned
…isible-on-member-info

fix: scrollbar in member list in group info was not visible
* Main Release 1.3.7 (#1334)

* fixed chat responsiveness

* fixed preview link alignment to right

* added relative imports for better management

* Search issue (#1270)

* fix: fixed lint issues

* fix: added test for chat preview search list

* fix: fixed review comment

* Update ChatPreviewSearchList.tsx

* fix: fixed support chat init issue (#1292)

* fix: fixed support chat init issue

* fix: fixed lint errors

* fix(chatviewlist): increase hidden/encrypted chat blur

fix #1307

* Added Reaction support,  (#1303)

* Fixed responsiveness in mobile for UIWeb:Chat

* fixes text alignment on frames preview link to come on right

* scroll bar fixes

* fixed reaction picker position, tweaked group type text, removed add button from define conditions in gated group

* removed unnecessary console.debug

* removed unnecessary console.debug

* Resolved comments, fixed curved edges go away, fixed correct time placement in ChatBubble

* Resolved comments

* fix: add selected option

* fix: add return fn

* fix: add comment to fn

* fix: add push bot address

* fix: export const

* fix: reset chat_id

* fix: remove console

* fix: update dark mode theme

* fix: code review comments

* fix: add null check

* fix: update conditions

* fix: update chatprevie badge conditions

* Space - id integration (#1322)

* feat: integrating spaceid in uiweb

* fix: fixed project id setting error

* fix: removed unnecessary code

* fix: added space id

* Update AddWallets.tsx

* fix: made some optimisations

* fix: fixed lint issues

---------

Co-authored-by: KlausMikhaelson <satyamsingh5076@gmail.com>

* fix: fixed the blurr issue in chat on join and accept group (#1305)

* fix: fixed lint issue

---------

Co-authored-by: harshrajat <harsh@epns.io>
Co-authored-by: Harsh | Push <harsh@push.org>
Co-authored-by: Monalisha Mishra <42746736+mishramonalisha76@users.noreply.github.com>
Co-authored-by: Mohammed S <shoaibmohammed92@gmail.com>
Co-authored-by: corlard3y <corlardey@gmail.com>
Co-authored-by: KlausMikhaelson <satyamsingh5076@gmail.com>
Co-authored-by: Monalisha Mishra <mishramonalisha76@gmail.com>

* Main Release 1.3.7 - Build error fixed (#1335)

* fix: fixed the ui representation of the domain name

* fix: fixed the domain representation in chatProfile

* fix: added utility func to fetch display name

* fix: added new function to check includes

---------

Co-authored-by: Rohit Malhotra <rohit.malhotra1420@gmail.com>
Co-authored-by: harshrajat <harsh@epns.io>
Co-authored-by: Harsh | Push <harsh@push.org>
Co-authored-by: Mohammed S <shoaibmohammed92@gmail.com>
Co-authored-by: corlard3y <corlardey@gmail.com>
Co-authored-by: KlausMikhaelson <satyamsingh5076@gmail.com>
* fix: updated guild validation url

* Update tokenGatedGroup.ts
Copy link

I checked the provided code and found some issues:

In ChatPreviewList.tsx:

  1. In the useEffect hook for chat accept, there is a missing closing curly brace } before the closing bracket of the hook.
  2. In the useEffect hook for chat reject, there is also a missing closing curly brace } before the closing bracket of the hook.
  3. In the handleSearch function, there are missing closing curly braces } for the inner if statement and the innermost if statement.
  4. In the handleSearch function, there is a missing closing parenthesis in the condition of the first if.

In ChatPreviewSearchList.tsx:

  1. In the loadMoreChats function, there is a missing closing parenthesis after the catch block.
  2. In the loadMoreChats function, there is a missing closing curly brace } at the end of the function.
  3. In the same loadMoreChats function, there is a missing closing curly brace } before the else if block.
  4. There is a missing closing parenthesis for the condition of the main if statement in the loadMoreChats function.
  5. In the same loadMoreChats function, there is a missing closing parenthesis for the main condition for the resolved = true block.
  6. In the ChatPreviewSearchListErrorCodes import, there is a typo 'ChatPreview' instead of 'ChatPreviewSearch'

In ChatProfile.tsx:

  • The file is empty.

In ChatProfileInfoModal.tsx:

  • There is a missing closing curly brace } at the end of the file.

In ChatViewList.tsx, MessageInput.tsx, helpers/helper.ts, helpers/tokenGatedGroup.ts, helpers/search.ts, and helpers/utils.ts:

  • The files are empty.

Please correct these issues and then re-run the code review.

@rohitmalhotra1420 rohitmalhotra1420 merged commit df8bf80 into main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants