Add support for setting trusted proxies #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the |
|
Does this really break the application? As far as I can see this only affects how the client IP is read. Do not see where we even use that? |
|
Ah, you're actually right! Only thing that would change is the IP address shown in the log output: it would always show the IP of your proxy if that proxy is not configured as trusted. |
CubicrootXYZ
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch closes #53, addressing a warning by the Gin framework not to trust all proxies.
@CubicrootXYZ, in its current state the changes would break existing configurations where PushBits runs behind a proxy. One can make the case to force breaking these configurations for the sake of the user's security, so I'd like to have your input on this :)