Fix login page fragment handling after soft reload on Firefox #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
|
(Rebased to resolve conflicts.) |
JoelSpeed
previously approved these changes
Jan 26, 2020
|
(Rebased to resolve conflicts.) |
loshz
requested changes
Jan 28, 2020
templates.go
Outdated
Comment on lines
138
to
143
| var idx = inputs[i].value.indexOf('#'); | ||
| if (idx >= 0) { | ||
| inputs[i].value = inputs[i].value.substr(0, idx); | ||
| } |
There was a problem hiding this comment.
Would you mind adding a brief comment to outline what happens here.
There was a problem hiding this comment.
Sure. I added comments, I hope it's now easier to understand!
|
Apologies @ffdybuster, because we have recently cut a release, the changelog entry you've added is in the wrong place now, if you could move it up to the new heading, then I'm happy to get this merged 👍 |
|
@JoelSpeed thanks, I overlooked that it ended up in the wrong place. I've updated the PR. |
JoelSpeed
approved these changes
Jan 31, 2020
loshz
approved these changes
Jan 31, 2020
|
@JoelSpeed @syscll thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #352.
Motivation and Context
Soft reloads on Firefox screw up the redirect link on the sign in page; see #352 for details.
How Has This Been Tested?
I've downloaded the generated sign in page, manually applied the change from this PR, opened it in Firefox and tested it there (with the developers tools).
Checklist: