Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncIOBackend logs 'unclosed client session' error on each trigger() #108

Closed
zdexter opened this issue Jan 29, 2018 · 5 comments
Closed

AsyncIOBackend logs 'unclosed client session' error on each trigger() #108

zdexter opened this issue Jan 29, 2018 · 5 comments

Comments

@zdexter
Copy link

zdexter commented Jan 29, 2018 •
edited
Loading

pusher==1.7.3 and aiohttp==2.3.9

pusher.trigger any message, and you'll see the following error if you have logging enabled (this is reported as an error level event to any attached tracing software etc, so it generates a lot of spam):

Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7f3c9004dba8>
@zdexter zdexter changed the title AIOHttpBackend generates 'unclosed client session AIOHttpBackend generates 'unclosed client session' Jan 29, 2018
@zdexter zdexter changed the title AIOHttpBackend generates 'unclosed client session' AsyncIOBackend generates 'unclosed client session' Jan 29, 2018
@zdexter zdexter changed the title AsyncIOBackend generates 'unclosed client session' AsyncIOBackend generates 'unclosed client session' error Jan 29, 2018
@zdexter zdexter changed the title AsyncIOBackend generates 'unclosed client session' error AsyncIOBackend logs 'unclosed client session' error on each trigger() Jan 29, 2018
@zdexter
Copy link
Author

zdexter commented Jan 29, 2018

the logger that generates this error is the asyncio logger.

@zdexter
Copy link
Author

zdexter commented Jan 29, 2018

aio-libs/aiohttp#1175

@callum-oakley callum-oakley mentioned this issue Feb 2, 2018
Merged
@callum-oakley
Copy link
Contributor

Hi @zdexter 👋

Sorry for the delay getting back to you on this. Thanks for the report and the link to the relevant issue upstream. I think this should do the trick #109 . Will aim to get this merged and a new version released asap.

@callum-oakley
Copy link
Contributor

Should be fixed in 1.7.4 :)

@zdexter
Copy link
Author

zdexter commented Feb 5, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zdexter @callum-oakley