Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rack dependency #33

Closed
oriolgual opened this Issue Jan 10, 2013 · 2 comments

Comments

Projects
None yet
2 participants

Right now Rack is declared as a development dependency but Pusher::WebHook uses Rack::Request here.

There are two solutions: add Rack as a dependency or (better IMO) change the if to something that just checks if the given object quacks like a Rack::Request.

What do you think?

Contributor

mloughran commented Jan 26, 2013

Yes this is a good point. We use rather a lot of methods to check for all those quacks, how about something like this?

if defined?(Rack::Request) && request.kind_of?(Rack::Request)

Works for me :)

@mloughran mloughran closed this in ee64a77 Feb 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment