-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventDispatcher does not implement an unbind
method
#12
Comments
+1 EventsDispatcher.prototype.unbind = function(event_name, callback) {
var index = this.callbacks[event_name].indexOf(callback)
this.callbacks[event_name].splice(index, 1)
return this;// chainable
}; |
+1 for this |
+1!! It's very important to allow unbind when some component is destroyed. For example, using ExtJS: cmp.mon( pusher_channel, 'event_name', callback ); |
+1! When is the 1.10.0 release slated for? |
1.10 has been release but the |
🆙 |
Version 1.11 of the Pusher JavaScript library now implements the You can see the implementation here: |
This has been raised a few times so it would be good to have this added to the
EventDispatcher
object:https://github.com/pusher/pusher-js/blob/master/src/pusher_event_dispatcher.js
The text was updated successfully, but these errors were encountered: