Skip to content

Commit

Permalink
Merge pull request #44 from davout/master
Browse files Browse the repository at this point in the history
Fix tests
  • Loading branch information
zimbatm committed Jan 5, 2015
2 parents 33c229c + fb41cd9 commit 247d125
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions spec/pusherclient_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@
end

it 'should not be subscribed by default' do
expect(@channel.subscribed).to be_false
expect(@channel.subscribed).to be_falsey
end

it 'should not be global by default' do
expect(@channel.global).to be_false
expect(@channel.global).to be_falsey
end

it 'can have procs bound to an event' do
Expand All @@ -67,7 +67,7 @@
end

it 'should not connect when instantiated' do
expect(@socket.connected).to be_false
expect(@socket.connected).to be_falsey
end

it 'should raise ArgumentError if TEST_APP_KEY is an empty string' do
Expand All @@ -85,21 +85,21 @@
end

it 'should know its connected' do
expect(@socket.connected).to be_true
expect(@socket.connected).to be_truthy
end

it 'should know its socket_id' do
expect(@socket.socket_id).to eq('123abc')
end

it 'should not be subscribed to its global channel' do
expect(@socket.global_channel.subscribed).to be_false
expect(@socket.global_channel.subscribed).to be_falsey
end

it 'should subscribe to a channel' do
@channel = @socket.subscribe('testchannel')
expect(@socket.channels['testchannel']).to eq(@channel)
expect(@channel.subscribed).to be_true
expect(@channel.subscribed).to be_truthy
end

it 'should unsubscribe from a channel' do
Expand All @@ -112,31 +112,31 @@
it 'should subscribe to a private channel' do
@channel = @socket.subscribe('private-testchannel')
expect(@socket.channels['private-testchannel']).to eq(@channel)
expect(@channel.subscribed).to be_true
expect(@channel.subscribed).to be_truthy
end

it 'should subscribe to a presence channel with user_id' do
@channel = @socket.subscribe('presence-testchannel', '123')
expect(@socket.channels['presence-testchannel']).to eq(@channel)
expect(@channel.user_data).to eq('{"user_id":"123"}')
expect(@channel.subscribed).to be_true
expect(@channel.subscribed).to be_truthy
end

it 'should subscribe to a presence channel with custom channel_data' do
@channel = @socket.subscribe('presence-testchannel', :user_id => '123', :user_name => 'john')
expect(@socket.channels['presence-testchannel']).to eq(@channel)
expect(@channel.user_data).to eq('{"user_id":"123","user_name":"john"}')
expect(@channel.subscribed).to be_true
expect(@channel.subscribed).to be_truthy
end

it 'should allow binding of global events' do
@socket.bind('testevent') { |data| PusherClient.logger.test("testchannel received #{data}") }
expect(@socket.global_channel.callbacks.has_key?('testevent')).to be_true
expect(@socket.global_channel.callbacks.has_key?('testevent')).to be_truthy
end

it 'should trigger callbacks for global events' do
@socket.bind('globalevent') { |data| PusherClient.logger.test("Global event!") }
expect(@socket.global_channel.callbacks.has_key?('globalevent')).to be_true
expect(@socket.global_channel.callbacks.has_key?('globalevent')).to be_truthy

@socket.simulate_received('globalevent', 'some data', '')
expect(PusherClient.logger.test_messages.last).to include('Global event!')
Expand All @@ -149,7 +149,7 @@

it 'should not be connected after disconnecting' do
@socket.disconnect
expect(@socket.connected).to be_false
expect(@socket.connected).to be_falsey
end

describe "when subscribed to a channel" do
Expand All @@ -159,7 +159,7 @@

it 'should allow binding of callbacks for the subscribed channel' do
@socket['testchannel'].bind('testevent') { |data| PusherClient.logger.test(data) }
expect(@socket['testchannel'].callbacks.has_key?('testevent')).to be_true
expect(@socket['testchannel'].callbacks.has_key?('testevent')).to be_truthy
end

it "should trigger channel callbacks when a message is received" do
Expand Down

0 comments on commit 247d125

Please sign in to comment.