This repository has been archived by the owner on May 4, 2021. It is now read-only.
Changed behaviors: alt title parsing and user id parsing on profiles #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A better option may be to use the report button as it also contains an ID and doesn't require a login. |
|
Will change it to that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative titles
There are many pages where there are no alternative titles and it's a bit annoying that the logic throws an exception so I've changed it to just produce an empty dict.
User profiles
It looks like MAL has changed the stuff a bit. The RSS link to the blog feed doesn't contain the user id anymore. Fortunately I could find it on the friend request button.
Fixes: #34 and #35