Fixing duplicate key warning when minDate or maxDate

[monteiz]

Motivation and Context

If minDate or maxDate are set, several duplicate key warnings are raised. This commit fix that.
Moreover, the handleClick function binding has been moved out from the render method for potentially performance reasons:

We generally recommend binding in the constructor or using the property initializer syntax, to avoid this sort of performance problem.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[travellingprog]

Thanks, I'm not the library maintainer but I came across this bug too and I'm glad you already fixed it in your branch. You should fix the indentation in your changes, though.

[travellingprog]

For people who want to remove this warning from their browser console, I made a fork of monteiz' branch where I ran the build process, to update the imported library.

With Yarn, you can use this build by running:
yarn add https://github.com/travellingprog/react-bootstrap-date-picker#fix-duplicate-key-warning

You should also be able to grab this branch with a regular NPM install, I believe by specifying a specific commit rather than the branch name, but i haven't tried it.

[monteiz]

Hi @travellingprog,
please submit a pull request to my fork. In case @pushtell shows up again, he can quickly merge the fix and everybody is happy.

[travellingprog]

@monteiz done

I also found and fixed another min/maxDate related bug in another branch (#137). And I have a 3rd branch that has both fixes (https://github.com/travellingprog/react-bootstrap-date-picker/tree/fix-makeDateValue-bug).

That's the branch I'm using in my app now, installed with

yarn add "https://github.com/travellingprog/react-bootstrap-date-picker#fix-makeDateValue-bug"

[JonShort]

I've tested these changes locally, everything seems fine - the errors in the unit tests seem to be fixed by this also 👍