Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot resolve @StorIOSQLiteCreator #727

Closed
saket opened this issue Dec 6, 2016 · 23 comments
Closed

Cannot resolve @StorIOSQLiteCreator #727

saket opened this issue Dec 6, 2016 · 23 comments

Comments

@saket
Copy link

saket commented Dec 6, 2016

Hello, I'm using the latest version of the library (1.11.0) and I cannot seem to be able to find @StorIOSQLiteCreator. I've these dependencies in my build.gradle file:

compile 'com.pushtorefresh.storio:sqlite:1.11.0'
compile 'com.pushtorefresh.storio:sqlite-annotations:1.11.0'
apt 'com.pushtorefresh.storio:sqlite-annotations-processor:1.11.0'

Any idea what I'm missing?

@geralt-encore
Copy link
Collaborator

Version with @StorIOSQLiteCreator hasn't been released yet. It should be available in 1.12 version. @artem-zinnatullin and @nikitin-da can say more about estimated release date.

@saket
Copy link
Author

saket commented Dec 6, 2016

Well, it's slightly confusing if you are adding unreleased features into your README :)

Is it possible to use a snapshot version?

@geralt-encore
Copy link
Collaborator

I understand you. It is particularly my fault since I have done PR with README update, but I didn't expect that it will be merged before the new version. Sorry for the confusion.
I think it should be possible to add current master snapshot using jitpack.

@saket
Copy link
Author

saket commented Dec 6, 2016

A snapshot version will be really awesome. If that doesn't happen, we'll be forced to use something else :(

@artem-zinnatullin
Copy link
Member

artem-zinnatullin commented Dec 6, 2016 via email

@nikitin-da
Copy link
Collaborator

@Saketme check please 1.12.0!

@saket
Copy link
Author

saket commented Dec 16, 2016

@nikitin-da I'm seeing this error:

Error:(37, 8) error: Please annotate class AutoValue_KiteNotification with StorIOSQLiteType

@geralt-encore
Copy link
Collaborator

@Saketme can you please show your class if it is possible?

@artem-zinnatullin
Copy link
Member

Daaamn. @geralt-encore looks like because of annotation processing rounds our annotation processor sees class generated by AutoValue, or I'm wrong

@saket
Copy link
Author

saket commented Dec 16, 2016

Sure, but can I email it to you instead?

@geralt-encore
Copy link
Collaborator

@Saketme there is no more need I have been able to reproduce it.
@artem-zinnatullin the problem is, that AutoValue classes also inherit annotations from the original class methods. I think that the easiest solutions will be skipping classes which names start from AutoValue_.
I am deeply sorry because this is completely my fault and lack of proper testing. I was testing it using just regular abstract java classes assuming that it will be the same for AutoValue case.

@artem-zinnatullin
Copy link
Member

artem-zinnatullin commented Dec 16, 2016 via email

@geralt-encore
Copy link
Collaborator

Inherit class level annotation is not an option because then we will get two tables and that is not what we really need. After quick googling I haven't found anything related to annotations inheritance in AutoValue.

@artem-zinnatullin
Copy link
Member

artem-zinnatullin commented Dec 16, 2016 via email

@geralt-encore
Copy link
Collaborator

I think it has to be AutoValue specific because I remember that while working on others project annotation processor it didn't come up by default.

@artem-zinnatullin
Copy link
Member

artem-zinnatullin commented Dec 16, 2016 via email

@geralt-encore
Copy link
Collaborator

@artem-zinnatullin so specific ignore then or you have a better idea?

@artem-zinnatullin
Copy link
Member

artem-zinnatullin commented Dec 16, 2016 via email

@geralt-encore
Copy link
Collaborator

I also was thinking about it but then I thought that if we want to introduce support for inheritance in future it might be a bad idea.

@artem-zinnatullin
Copy link
Member

artem-zinnatullin commented Dec 16, 2016 via email

@geralt-encore
Copy link
Collaborator

@Saketme please verify that the issue is fixed in the latest version.

@saket
Copy link
Author

saket commented Jan 3, 2017

@geralt-encore I'm sorry, I didn't realize a fix has already been released. I will test the new version and report back.

@nikitin-da
Copy link
Collaborator

Closing. Feel free to reopen if you met some problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants