Implement createObservable for PreparedGetObject

[geralt-encore]

I am not sure about my integration tests

[artem-zinnatullin]

static import for milliseconds please :)

[artem-zinnatullin]

Looks good! Just few comments.

[artem-zinnatullin]

@nikitin-da PTAL :)

[nikitin-da]

Maybe shouldGetObjectByQueryWithoutTypeMappingAsObservable will be better=)

[nikitin-da]

👍 LGTM

[artem-zinnatullin]

Would be nice to also have integration tests to see that it reacts on changes of tables from query and emits new result!

[geralt-encore]

Ok, I will get my hands on it today in the evening

[artem-zinnatullin]

Thanks!

[geralt-encore]

@artem-zinnatullin check this out!

[artem-zinnatullin]

Unneeded Blocking in test name

[artem-zinnatullin]

Checked 👯

[geralt-encore]

But without this testSubscriber.awaitTerminalEvent(500, MILLISECONDS) my tests are failing. If I could somehow change Schedulers.io() to Schedulers.immediate() i would fix problem, but I couldn't find easy solution for it

[artem-zinnatullin]

testSubscriber.awaitTerminalEvent is just an attempt to wait, tests can fail on slow computer.

Better to do take(1), etc to explicitly set expected number of items and then do awaitTerminalEvent() with huge timeout just to break the test if something gone wrong!

[geralt-encore]

Will it be something like that?

  @Test
public void queryOneExistedObjectObservable() {
    final List<User> users = putUsersBlocking(3);
    final User expectedUser = users.get(0);

    final Observable<User> userObservable = storIOSQLite
            .get()
            .object(User.class)
            .withQuery(Query.builder()
                    .table(UserTableMeta.TABLE)
                    .where(UserTableMeta.COLUMN_EMAIL + "=?")
                    .whereArgs(expectedUser.email())
                    .build())
            .prepare()
            .createObservable()
            .take(1);

    TestSubscriber<User> testSubscriber = new TestSubscriber<User>();
    userObservable.subscribe(testSubscriber);

    testSubscriber.awaitTerminalEvent(5, SECONDS);
    testSubscriber.assertValueCount(1);
    testSubscriber.assertValue(expectedUser);
    testSubscriber.assertNoErrors();
    testSubscriber.unsubscribe();
}

[artem-zinnatullin]

Yep, looks good, you can remove assertValueCount() because assertValue() checks values count :)

[geralt-encore]

Tests are fixed now

[artem-zinnatullin]

Not needed but I think I'll merge it anyway :)

[artem-zinnatullin]

👍 thanks again!

[geralt-encore]

I'll try to finish Rx part for content resolver by the end of this week. Could you explain why calling unsubscribe for TestSubscriber is unnecessary? Sorry for a huge amount of defects in this PR =(

[artem-zinnatullin]

@geralt-encore no problems! You help us a lot (I'm busy as always)! Also, you learned some Rx and that's great :)