Default scheduler handling for storIOContentResolver #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.95%@@ master #661 diff @@
==========================================
Files 86 87 +1
Lines 2484 2445 -39
Methods 0 0
Messages 0 0
Branches 322 326 +4
==========================================
- Hits 2386 2346 -40
Misses 69 69
- Partials 29 30 +1
|
nikitin-da
force-pushed
the
issue-511-content-resolver
branch
from
c9f1460
to
04baa3c
Compare
| @@ -139,6 +155,9 @@ public CompleteBuilder contentResolver(@NonNull ContentResolver contentResolver) | |||
| @Nullable | |||
| private Handler contentObserverHandler; | |||
|
|
|||
| @Nullable | |||
| private Scheduler defaultScheduler = RX_JAVA_IS_IN_THE_CLASS_PATH ? Schedulers.io() : null; | |||
nikitin-da
force-pushed
the
issue-511-content-resolver
branch
from
04baa3c
to
3bb9005
Compare
nikitin-da
force-pushed
the
issue-511-content-resolver
branch
2 times, most recently
from
25c1e1f
to
8e7f98a
Compare
| .contentResolver(mock(ContentResolver.class)) | ||
| .build(); | ||
|
|
||
| assertThat(storIOContentResolver.defaultScheduler()).isEqualTo(io()); |
|
👍 (few nits) Dude this is crazy! |
nikitin-da
force-pushed
the
issue-511-content-resolver
branch
from
8e7f98a
to
5cfa25a
Compare
|
@artem-zinnatullin hehe, but 0.1% decrease 😿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second part of #511