Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to RawQuery affectsTables and observesTables that take collection #698

Merged
merged 1 commit into from Oct 23, 2016

Conversation

nikitin-da
Copy link
Collaborator

Closes #696

@nikitin-da nikitin-da added this to the v1.12.0 milestone Oct 21, 2016
@nikitin-da nikitin-da self-assigned this Oct 21, 2016
@codecov-io
Copy link

codecov-io commented Oct 21, 2016

Current coverage is 96.05% (diff: 100%)

Merging #698 into master will increase coverage by 0.01%

@@             master       #698   diff @@
==========================================
  Files            87         87          
  Lines          2447       2457    +10   
  Methods           0          0          
  Messages          0          0          
  Branches        327        329     +2   
==========================================
+ Hits           2350       2360    +10   
  Misses           68         68          
  Partials         29         29          

Powered by Codecov. Last update a035337...591dd43

@artem-zinnatullin
Copy link
Member

Hm, not sure I like that you can call both new and old api and it'll clear previous state…

@nikitin-da
Copy link
Collaborator Author

I think adding to existing collection will be more complicated=(
And yet another level of builder that will protect calling both methods in compile time looks
strangely

@artem-zinnatullin
Copy link
Member

Ok, let's add this variant, I've checked other libs with multiple methods of setting same value, they all rewrite result of previos call

@artem-zinnatullin artem-zinnatullin merged commit 2aeaea6 into master Oct 23, 2016
@artem-zinnatullin artem-zinnatullin deleted the issue-696 branch October 23, 2016 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants