Add SQLDelight interaction example #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 89 89
Lines 2692 2692
Branches 302 302
=======================================
Hits 2622 2622
Misses 38 38
Partials 32 32Continue to review full report at Codecov.
|
artem-zinnatullin
requested changes
Aug 13, 2017
|
|
||
| private List<Customer> customers; | ||
|
|
||
| public void setCustomers(@Nullable List<Customer> customers) { |
There was a problem hiding this comment.
Let's not allow null and just pass empty list if needed?
|
|
||
| @Override | ||
| public ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) { | ||
| return new ViewHolder(LayoutInflater.from(parent.getContext()) |
There was a problem hiding this comment.
Cache LayoutInflater?
There was a problem hiding this comment.
I would accept it as constructor parameter
| return mapFromCursor(cursor, Customer.CURSOR_MAPPER); | ||
| } | ||
| }) | ||
| .delay(1, SECONDS) |
| void addContent() { | ||
| final List<Customer> customers = new ArrayList<Customer>(); | ||
|
|
||
| customers.add(Customer.builder().name("Artem").surname("Zinnatullin").city("SF").build()); |
There was a problem hiding this comment.
I would remove that though :D
| @@ -0,0 +1,16 @@ | |||
| import java.lang.Float; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #785
//cc @thevery @StanisVS