Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part2. Implement optional for SQLite #848

Merged
merged 2 commits into from Nov 13, 2017
Merged

Part2. Implement optional for SQLite #848

merged 2 commits into from Nov 13, 2017

Conversation

nikitin-da
Copy link
Collaborator

Part of #685

Feedback about Optional class implementation is welcome ;)

@nikitin-da nikitin-da self-assigned this Nov 12, 2017
@nikitin-da nikitin-da added this to the v3.0.0 milestone Nov 12, 2017
@codecov-io
Copy link

codecov-io commented Nov 12, 2017

Codecov Report

Merging #848 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #848      +/-   ##
============================================
+ Coverage     97.24%   97.33%   +0.09%     
- Complexity      778      799      +21     
============================================
  Files            91       92       +1     
  Lines          2646     2662      +16     
  Branches        297      298       +1     
============================================
+ Hits           2573     2591      +18     
+ Misses           45       44       -1     
+ Partials         28       27       -1
Impacted Files Coverage Δ Complexity Δ
...orio2/sqlite/operations/delete/PreparedDelete.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...qlite/operations/delete/PreparedDeleteByQuery.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...esh/storio2/sqlite/operations/put/PreparedPut.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...esh/storio2/sqlite/operations/get/PreparedGet.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...tentresolver/operations/get/PreparedGetObject.java 100% <ø> (ø) 7 <0> (ø) ⬇️
...shtorefresh/storio2/sqlite/LoggingInterceptor.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...om/pushtorefresh/storio2/test/ToStringChecker.java 79.72% <100%> (+2.09%) 23 <0> (ø) ⬇️
...m/pushtorefresh/storio2/sqlite/impl/ChainImpl.java 100% <100%> (ø) 5 <0> (ø) ⬇️
.../main/java/com/pushtorefresh/storio2/Optional.java 100% <100%> (ø) 21 <21> (?)
...orio2/sqlite/operations/get/PreparedGetObject.java 100% <100%> (ø) 5 <1> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a6c2b...3de5b42. Read the comment docs.

Copy link
Collaborator

@geralt-encore geralt-encore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nikitin-da nikitin-da changed the title Implement optional for SQLite Part2. Implement optional for SQLite Nov 12, 2017
@geralt-encore geralt-encore merged commit 5850b7e into master Nov 13, 2017
@nikitin-da nikitin-da deleted the optionl-sqlite branch December 3, 2017 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants